[python] Add paired ACT storage benchmark - #9466
Merged
Merged
Conversation
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
from
August 29, 2026 14:53
622ceae to
5d8890e
Compare
YannByron
marked this pull request as draft
August 29, 2026 14:54
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
2 times, most recently
from
September 1, 2026 03:24
fb77b0e to
7b2b5a4
Compare
YannByron
marked this pull request as ready for review
September 1, 2026 03:51
YannByron
marked this pull request as draft
September 1, 2026 03:52
YannByron
marked this pull request as ready for review
September 2, 2026 01:14
JingsongLi
reviewed
Sep 2, 2026
JingsongLi
reviewed
Sep 2, 2026
JingsongLi
reviewed
Sep 2, 2026
JingsongLi
reviewed
Sep 2, 2026
JingsongLi
reviewed
Sep 2, 2026
JingsongLi
reviewed
Sep 2, 2026
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
from
September 2, 2026 09:16
42be5b2 to
705683a
Compare
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
from
September 3, 2026 02:48
705683a to
9e0340a
Compare
Contributor
|
Thanks for putting this together. This PR currently combines two independently valuable changes with different review and risk profiles: the generic ContiguousWindowDataset public API, and the RoboMIND ACT benchmark harness and workflow. Given the 4.4k-line scope, could we split this into two PRs?
This would make the public API easier to review on its own, while allowing the benchmark methodology and reproducibility contract to be evaluated independently. It would also keep follow-up fixes in either area from blocking the other. |
6 tasks
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
from
September 8, 2026 14:21
9e0340a to
78207fc
Compare
JingsongLi
reviewed
Sep 8, 2026
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
Three actionable issues found in the updated benchmark-only scope.
Rebuild the benchmark-only change on top of the merged contiguous-window dataset. Compare equivalent HDF5 and Paimon ACT inputs and use frame_index consistently in the public sample contract. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-5 Co-Authored-By: Codex <noreply@ai-tool.com> Co-Authored-By: Codex <noreply@openai.com> AI-Contributed/Feature: 181/2395 AI-Contributed/UT: 687/895
Align RoboMIND fields and formats with the public data contract, compare action statistics in the canonical numeric domain, and keep validation reads outside benchmark timing. Co-Authored-By: Codex <noreply@anthropic.com> AI-Model: gpt-5 AI-Contributed/Feature: 71/71 AI-Contributed/UT: 57/57
YannByron
force-pushed
the
m0/pr3-act-benchmark
branch
from
September 9, 2026 08:06
78207fc to
556278e
Compare
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a reproducible paired ACT benchmark for equivalent RoboMIND data stored in HDF5 and Paimon.
This PR now contains only the benchmark. It builds on the snapshot-pinned
ContiguousWindowDatasetmerged in #9580.Changes
prepare,run, andcomparecommands for independent HDF5 and Paimon runs using one resolved experiment.frame_indexconsistently as the ACT sample position across both storage backends.Testing
master(d95ebff28).4701 passed, 78 skippedon Python 3.13.48 passed, 1 skipped.git diff --check.Notes